Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Cannot read property 'some' of undefined #944

Merged
merged 1 commit into from
Oct 13, 2017
Merged

Fixes Cannot read property 'some' of undefined #944

merged 1 commit into from
Oct 13, 2017

Conversation

alexgorbatchev
Copy link
Contributor

Closes #842

@alexgorbatchev
Copy link
Contributor Author

Oddly, master currently has 28 failing tests. I checked that after this change there are sill 28 failing tests.

@ljharb
Copy link
Member

ljharb commented Oct 13, 2017

hmm, I only get 1 failing test locally on master (which I'm fixing momentarily)

@ljharb
Copy link
Member

ljharb commented Oct 13, 2017

@alexgorbatchev would you mind rebasing on top of latest master?

@alexgorbatchev alexgorbatchev force-pushed the alexgorbatchev/issue-842 branch from f89152b to c246b9e Compare October 13, 2017 17:04
@alexgorbatchev
Copy link
Contributor Author

Rebased. I think the tests are failing on Windows. Ran it OSX and it was as you said, just one. No failures on OSX after the rebase.

@coveralls
Copy link

coveralls commented Oct 13, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.002%) to 96.032% when pulling c246b9e on alexgorbatchev:alexgorbatchev/issue-842 into 1958e0b on benmosher:master.

2 similar comments
@coveralls
Copy link

coveralls commented Oct 13, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.002%) to 96.032% when pulling c246b9e on alexgorbatchev:alexgorbatchev/issue-842 into 1958e0b on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 96.032% when pulling c246b9e on alexgorbatchev:alexgorbatchev/issue-842 into 1958e0b on benmosher:master.

@ljharb
Copy link
Member

ljharb commented Oct 13, 2017

We'll have to deal with the windows failures later I guess.

@ljharb ljharb merged commit cef88f2 into import-js:master Oct 13, 2017
@alexgorbatchev alexgorbatchev deleted the alexgorbatchev/issue-842 branch October 14, 2017 00:02
@alexgorbatchev
Copy link
Contributor Author

Could you please publish this to NPM when you get a chance?

benmosher added a commit that referenced this pull request Oct 18, 2017
@benmosher
#842/#944 changelog note
4071379
This was referenced Apr 15, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexgorbatchev @ljharb @coveralls